Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Drop python 3.8 and support python 3.13 for schema tools #1947

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 8, 2024

  • closes none
  • for bids schema tools: drop python 3.8 and supports 3.13

@Remi-Gau Remi-Gau requested a review from erdalkaraca as a code owner October 8, 2024 13:22
@Remi-Gau Remi-Gau added the exclude-from-changelog This item will not feature in the automatically generated changelog label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (adddd09) to head (ab45624).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1947      +/-   ##
==========================================
- Coverage   87.23%   86.87%   -0.36%     
==========================================
  Files          16       16              
  Lines        1410     1410              
==========================================
- Hits         1230     1225       -5     
- Misses        180      185       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this. If you've got the appetite, we can transition away from setup.cfg to pyproject.toml, but let's not pollute this PR, which is testing clean.

@effigies effigies merged commit 4b71e3a into bids-standard:master Oct 8, 2024
27 of 28 checks passed
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 8, 2024

If you've got the appetite, we can transition away from setup.cfg to pyproject.toml

yeah I was itching to do actually

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 8, 2024

yeah I was itching to do actually

please don't kink shame me... 🙈

@Remi-Gau Remi-Gau deleted the maint/py3.13 branch October 8, 2024 13:53
yarikoptic added a commit to yarikoptic/bids-specification that referenced this pull request Oct 28, 2024
…ttype

* commit 'v1.10.0-35-g5f7004819': (218 commits)
  Include entity-less "scans.json" into an example of inheritance principle (bids-standard#1945)
  fix(checks): Enforce timing mutual exclusions on BOLD/ASL data only (bids-standard#1969)
  refactor contributing (bids-standard#1965)
  [pre-commit.ci] pre-commit autoupdate (bids-standard#1967)
  [SCHEMA] Allow physio files for anat datatype (bids-standard#1961)
  [pre-commit.ci] pre-commit autoupdate
  Add an empty line in hope to get table rendered properly in "Ordering rules" section (bids-standard#1953)
  schema: add check for duplicate READMEs (bids-standard#1952)
  [MAINT] switch bidsschematools to pyproject.toml (bids-standard#1948)
  fix(schema): Disable TaskName check for channels and markers files
  Permit and warn on task/acquisition/run for electrodes and coordsystems
  [FIX] Allow (but discourage) task entity for coordsystem.json
  fix(schema): Limit MRI metadata checks to NIfTIs
  fix: Only check for sorted times in arrays
  py3.13 (bids-standard#1947)
  [pre-commit.ci] pre-commit autoupdate (bids-standard#1946)
  [FIX] Update changelog links to avoid redirects (bids-standard#1944)
  [ENH] Update DWI suffixes to include most common scanner derivatives (bids-standard#1864)
  [pre-commit.ci] pre-commit autoupdate
  [MAINT] Update Release_Protocol.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants